-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build OpenJ9 Windows jdk19+ with VS2022, and disable ccache #3251
Conversation
@AdamBrousseau fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In /github/workspace/build-farm/platform-specific-configurations/windows.sh line 227:
fi
^-- SC1089 (error): Parsing stopped here. Is this keyword correctly matched up?
OpenJ9 was missing the change to disable ccache for all versions. Issue eclipse-openj9/openj9#16701 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Oops, fixed now. |
OK the Alpine build is failing because it is merging/generating a file that has a merge conflict: <<<<<<< HEAD No idea where this is coming from as a GitHub code search indicates that's nowhere in the entire Adoptium org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does --disable-ccache
do anything on Windows JDK builds? I didn't think it was possible to use it there.
I don't know, I'm just making it consistent. 32-bit builds use it, non-openj9 builds use it, and openj9 jdk8 64-bit uses it. My change uses it for openj9 64-bit builds of all versions. |
@karianna Are you happy with this now after Peter addressed your request? |
The Alpine build still seems to have a merge conflict? |
I think we should try and align hotspot/openj9 better here. @sxa I think we were talking about bumping the Temurin builds to VS 2022 as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
That's the separate branch that MSFT is maintaining I believe - @gdams can you check this one? |
Possibly but we can do that under a separate PR if desired. At the moment all the work that is being done to enable reproducibility for Temurin is on VS2019 and additional work would be required to move it up. |
Can this be merged? |
I think we're still in release freeze. |
/thaw |
Pull Request unblocked - code freeze is over.
OpenJ9 was missing the change to disable ccache for all versions.
Issue eclipse-openj9/openj9#16701