Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDependentLibs should fail if the download step fails #204

Closed
llxia opened this issue Jun 8, 2021 · 0 comments · Fixed by #205
Closed

getDependentLibs should fail if the download step fails #204

llxia opened this issue Jun 8, 2021 · 0 comments · Fixed by #205
Labels
bug Something isn't working

Comments

@llxia
Copy link
Contributor

llxia commented Jun 8, 2021

Currently, the test script proceeds even if the download step fails in getDependentLibs.

     [exec] --------------------------------------------
     [exec] Starting download third party dependent jars
     [exec] --------------------------------------------
     [exec] downloading dependent third party jars to /home/runner/work/aqa-tests/aqa-tests/openjdk-tests/TKG/../TKG/lib
     [exec] downloading https://ci.eclipse.org/openj9/view/Infrastructure/job/Build_JDK_Timeout_Handler/lastSuccessfulBuild/artifact/openj9jtregtimeouthandler.jar.sha256sum.txt
     [exec] --> file downloaded to /home/runner/work/aqa-tests/aqa-tests/openjdk-tests/TKG/../TKG/lib/openj9jtregtimeouthandler.jar.sha256sum.txt
     [exec] downloading https://ci.eclipse.org/openj9/view/Infrastructure/job/Build_JDK_Timeout_Handler/lastSuccessfulBuild/artifact/openj9jtregtimeouthandler.jar
     [exec] --> file downloaded to /home/runner/work/aqa-tests/aqa-tests/openjdk-tests/TKG/../TKG/lib/openj9jtregtimeouthandler.jar
     [exec] downloading https://ci.eclipse.org/openj9/view/Infrastructure/job/Build_JDK_Timeout_Handler/lastSuccessfulBuild/artifact/openj9jtregtimeouthandler.jar.sha256sum.txt
     [exec] --> file downloaded to /home/runner/work/aqa-tests/aqa-tests/openjdk-tests/TKG/../TKG/lib/openj9jtregtimeouthandler.jar.sha256sum.txt
     [exec] Expected sha is: <!doctype,
     [exec] Actual sha is  : d46d58c000b511cd0fde4eb331fb09810511709ab0107974bb6148c583a3c2ff.
     [exec] ERROR: sha checksum error.
     [exec] Please delete /home/runner/work/aqa-tests/aqa-tests/openjdk-tests/TKG/../TKG/lib/openj9jtregtimeouthandler.jar and rerun the program!
     [exec] Result: 255
getJtreg:
    [mkdir] Created dir: /home/runner/work/aqa-tests/aqa-tests/jvmtest/openjdk
     [exec] gzip: jtreg_4_2_0_tip.tar.gz: No such file or directory

getDependentLibs should be updated.

<target name="getDependentLibs" unless="skipDependency">

@karianna karianna added the bug Something isn't working label Jun 8, 2021
renfeiw added a commit to renfeiw/TKG that referenced this issue Jun 8, 2021
Fixes adoptium#204

Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
@llxia llxia closed this as completed in #205 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants