Skip to content

Commit

Permalink
Bump mrml from 3.1.5 to 4.0.0 in /native/mjml_nif
Browse files Browse the repository at this point in the history
Version 4.0.0 fixes a bug if you use phoenix function components
to generate MJML and have heex annotations enabled by default.

Essentially the heex annotations add comments outside the <mjml> tag
and this was breaking the pareser.  The bug has been fixed upstream.

See jdrouet/mrml#409 for more info.
  • Loading branch information
moomerman committed Jun 18, 2024
1 parent 0cb7403 commit be2dc97
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 82 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ I.e. `mjml_nif 0.x` versions use mrml versions `>= 0.1, < 1.0.0`, and `mjml_nif

## [Unreleased]

## [4.0.0] - 2024-06-18

- Use [mrml] v4.0.0 which fixes a bug when using HEEx annotations and phoenix function components to generate MJML (see [mrml diff v3.1.5..v4.0.0][mrml-v3.1.5-v4.0.0])

## [3.1.0] - 2024-04-18

- Use [mrml] v3.1.5 (see [mrml diff v3.0.4..v3.1.5][mrml-v3.0.4-v3.1.5])
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ defmodule Mjml.MixProject do
use Mix.Project

@source_url "https://github.com/adoptoposs/mjml_nif"
@version "3.1.0"
@version "4.0.0"

def project do
[
Expand Down
143 changes: 64 additions & 79 deletions native/mjml_nif/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions native/mjml_nif/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mjml_nif"
version = "3.1.0"
version = "4.0.0"
authors = ["Paul Götze"]
edition = "2021"

Expand All @@ -11,7 +11,10 @@ crate-type = ["cdylib"]

[dependencies]
rustler = "0.33.0"
mrml = { version = "3.1", default-features = false, features = ["parse", "render", "orderedmap"] }
mrml = { version = "4.0", default-features = false, features = [
"parse",
"render",
] }

[features]
default = ["nif_version_2_15"]
Expand Down

0 comments on commit be2dc97

Please sign in to comment.