Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use orderedmap for rust mjml for consistent html output #63

Merged
merged 1 commit into from
May 25, 2022
Merged

use orderedmap for rust mjml for consistent html output #63

merged 1 commit into from
May 25, 2022

Conversation

tidusIO
Copy link
Contributor

@tidusIO tidusIO commented May 23, 2022

Hi :)
I made this pull request to use the orderedmap feature. It was released in 1.2.6 and it helps to get consistent HTML output.

jdrouet/mrml#215

Would be nice for adding this to the package and making a new release, since we got some troubles with unit tests and this will help to solve it.

@tidusIO tidusIO mentioned this pull request May 23, 2022
Closed
@paulgoetze paulgoetze merged commit e3eddf2 into adoptoposs:main May 25, 2022
@tidusIO tidusIO deleted the use_orderedmap branch May 25, 2022 16:56
@paulgoetze
Copy link
Member

paulgoetze commented May 25, 2022 •
edited
Loading

Thanks @tidusIO! Really nice catch 🙌 💜
I published a new version that includes your fix (v1.3.3).

@paulgoetze paulgoetze mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tidusIO @paulgoetze