Don't throw exception if access token is in JSON #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If params are passed as JSON (instead of array), check and see if the access token is part of the JSON. If it is, do not throw the "You need to give parameters as array if you want to give the token within the URI" exception.
Issue adoy#30 doesn't appear to have been merged. In addition, the http_parse_headers function here is a better implementation of parsing the headers - it accounts for a number of things that could be different about the headers.
|
@adoy ? Maybe not the best implementation, but the behavior change is wanted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If params are passed as JSON (instead of array), check and see if the access token is part of the JSON.
If it is, do not throw the "You need to give parameters as array if you want to give the token within the URI" exception.
For my example, the URL I pass to
fetch()has ?access_token=X as part of the URL string. I am passing my$paramsas a JSON string that also includes access_token.Without this change, I'm not sure how #6 was passing JSON
$paramsand not having this error be thrown.