Improve flexibility in the way ADRs are acquired and indexed #35
Conversation
wyrfel
force-pushed
the
feature/improve-adr-file-gathering
branch
4 times, most recently
from
dd7be2b
to
48cf736
Compare
Improves the way ADRs are acquired and indexed in the following ways - search recursively underneath the given directory - allow date prefixes as well as number prefixes - allow specification of `index` or `date` properties in frontmatter - fallback to auto-numbering for ADRs without filename prefixes or frontmatter - add -e option to specify glob pattern for files to be excluded
wyrfel
force-pushed
the
feature/improve-adr-file-gathering
branch
from
48cf736
to
f33cbf9
Compare
|
Hi @koppor . Could you please evaluate if these extensions would be something you would like to merge? |
|
Thank you for the PR. - JavaScript programming is not my main field. I wonder whether it is easy to add tests for the changes? Otherwise, I will have to manually test the changes. In any case, would you mind to add the change description to |
|
I did not test properly. Seems that it lists Can you work on it to fix it? |
| @@ -67,9 +69,15 @@ console.log("adr log file:", adrLogFile); | |||
| console.log("adr log dir:", adrLogDir); | |||
|
|
|||
| var headings = ''; | |||
| const globPattern = '!(' + adrLogFileName.slice(0,-3) + '*).md'; | |||
| const globPattern = '**/*.md'; | |||
There was a problem hiding this comment.
This creates a change in behaviour that causes all md files to be indexed, not just those with the prefix.
There was a problem hiding this comment.
This relates to the discussion at adr/madr#28
Another thing: Could you try log4brain's adr command? I am short of time currently, but the project seems promising. I am thinking of stopping this project and to recommend that one. WDYT?
Improves the way ADRs are acquired and indexed in the following ways
indexordateproperties in frontmatter