Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation #87

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Fix validation #87

merged 4 commits into from
Jun 16, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 12, 2022

  • Removes "validation" from "more information", because we already have "Validation" as section
  • Fixes level of "validation" --> sub heading of "Outcome", because it belongs to the outcome.

First #86 should be merged, then conflicts fixed and then this one finalized.

@socadk
Copy link
Contributor

socadk commented Nov 16, 2022

  • Removes "validation" from "more information", because we already have "Validation" as section

    • Fixes level of "validation" --> sub heading of "Outcome", because it belongs to the outcome.

First #86 should be merged, then conflicts fixed and then this one finalized.

@koppor I merged #86

@koppor koppor requested a review from socadk November 28, 2022 18:24
@socadk
Copy link
Contributor

socadk commented Dec 1, 2022

@koppor I think validation should be on same header level as Outcome and More Info: it is a consequence but not a part of the outcome. See https://medium.com/olzzio/the-markdown-adr-madr-template-explained-and-distilled-b67603ec95bb

Copy link
Contributor

@socadk socadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to go back to ##

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for madr-develop ready!

Name Link
🔨 Latest commit a966789
🔍 Latest deploy log https://app.netlify.com/sites/madr-develop/deploys/6449adb2cb4dd800081a9ad0
😎 Deploy Preview https://deploy-preview-87--madr-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@koppor koppor marked this pull request as ready for review June 16, 2023 13:44
@koppor koppor merged commit 21aa301 into develop Jun 16, 2023
@koppor koppor deleted the fix-validation branch June 16, 2023 13:47
@koppor koppor mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants