Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Github Actions workflows using the latest two versions of Go #74

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

nothub
Copy link
Contributor

@nothub nothub commented Mar 17, 2024

This changes the CI job to always use the Go version defined in the mod file. It also enables caching for module downloads.

@nothub
Copy link
Contributor Author

nothub commented Aug 18, 2024

Merged upstream to resolve conflicts.

@adrg
Copy link
Owner

adrg commented Aug 18, 2024

Hi @nothub,

Thank you for the PR. I apologize for the late response.

I would rather not use the version of Go specified in the go.mod file for the workflows. The minimum version of Go required by the module is currently 1.19 and I would like to run the actions using a more recent version.

I think it might be a better idea to use go-version: 'stable' or go-version: 'oldstable', or perhaps both using the matrix section. In any case, I would always get a newer Go version this way.

Reference: https://github.com/actions/setup-go?tab=readme-ov-file#using-stableoldstable-aliases

@nothub
Copy link
Contributor Author

nothub commented Aug 20, 2024

Hi @adrg,

I changed the used go-version to stable and oldstable with matrix strategy.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fdcc36e) to head (21d4306).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          392       392           
=========================================
  Hits           392       392           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrg
Copy link
Owner

adrg commented Aug 20, 2024

Hi @adrg,

I changed the used go-version to stable and oldstable with matrix strategy.

Thank you. Can you also change the golangci-lint binary version from v1.54 to latest in lint.yml? It seems Go 1.23 support was just added in version v1.60.1 of golangci-lint.

@nothub
Copy link
Contributor Author

nothub commented Aug 23, 2024

Yeah no problem 👍
The version of the golangci-lint step is now set to latest.

@adrg adrg changed the title Use go.mod version in CI Run Github Actions workflows using the latest two versions of Go Aug 23, 2024
@adrg adrg merged commit 61e983f into adrg:master Aug 23, 2024
16 checks passed
@adrg
Copy link
Owner

adrg commented Aug 23, 2024

@nothub Merged the PR. Thanks again. I also added you to the contributors list in README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants