Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes module #38

Merged
merged 9 commits into from
Jan 11, 2023
Merged

Quotes module #38

merged 9 commits into from
Jan 11, 2023

Conversation

adri0
Copy link
Owner

@adri0 adri0 commented Dec 30, 2022

  • Use yfinance for downloading quotes.
  • Save and load quotes as a dataframe in PERSIST directory.
  • Refactor model: move Transaction class to its own module, other models to a common module.

@adri0 adri0 added the enhancement New feature or request label Dec 30, 2022
@adri0 adri0 requested a review from mkopec87 December 30, 2022 18:33
@adri0 adri0 linked an issue Dec 30, 2022 that may be closed by this pull request
Quotes module #26
Closed
@adri0
Copy link
Owner Author

adri0 commented Dec 30, 2022

@mkopec87 Would you mind giving it a review? Sorry about the massive PR 😞

mkopec87
mkopec87 requested changes Jan 8, 2023
View reviewed changes
Copy link
Collaborator

@mkopec87 mkopec87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR :) I thing you missed to remove model.py during the merges

investd/__main__.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
investd/common.py Show resolved Hide resolved
tests/test_quotes.py Outdated Show resolved Hide resolved
tests/test_quotes.py Outdated Show resolved Hide resolved
tests/test_quotes.py Outdated Show resolved Hide resolved
investd/quotes.py Outdated Show resolved Hide resolved
@adri0 adri0 mentioned this pull request Jan 8, 2023
Open
@mkopec87
Copy link
Collaborator

@adri0 , shall I re-review? I'd expect for you to click the "re-request review" button next to my name in case the changes are ready :)

@adri0 adri0 requested a review from mkopec87 January 11, 2023 07:19
@adri0
Copy link
Owner Author

adri0 commented Jan 11, 2023

@adri0 , shall I re-review? I'd expect for you to click the "re-request review" button next to my name in case the changes are ready :)

Yes, would you mind? :) I'm just getting familiar with Github's code review now.

mkopec87
mkopec87 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@mkopec87 mkopec87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adri0
Copy link
Owner Author

adri0 commented Jan 11, 2023

LGTM!

LGTM?

Thanks for approving!

@adri0 adri0 merged commit 6498447 into main Jan 11, 2023
@mkopec87
Copy link
Collaborator

https://www.dictionary.com/e/acronyms/lgtm/ :)

@mkopec87
Copy link
Collaborator

Oh, I found a better page: https://www.urbandictionary.com/define.php?term=LGTM

So it's either:

  • Looks Good To Me
  • Let's Get This Merged
  • Literally Garbage To Me
  • Lesbian Gay Transagender Martian :D

@adri0 adri0 deleted the 26-quotes-module branch January 14, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkopec87 mkopec87 mkopec87 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quotes module
2 participants
@adri0 @mkopec87