-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P4 metric #36
Comments
Hola Davide! Gracias. P4 is a nice suggestion! Thanks, ADRIAN |
Hi Davide, Please, could you check that the new function p4() works as expected?? You may install the development version contained in the branch named 'update_P4' install.packages("devtools")devtools::install_github("adriancorrendo/metrica", ref = "update_P4") If you can confirm it works for you I will proceed to make the update to main branch and submit to CRAN. Thanks, Adrian |
Hi Adrian I tried to run one of your examples but unfortunately it did not work:
|
Thanks, Davide! Did you check that the library is loaded? The issue looks like because it does find the function. This is because the package is either not loaded or didn't install correctly. If you installed the version from the branch "update_P4" (with the code install_github(..., ref = "update_P4"), p4 should pop up when you type metrica::p4(...) Did you have any issue when installing from this specific branch? Thanks, Adrian |
Hola Adrian Best, -- Davide |
Awesome! You may expect to see the new version 2.0.4 on CRAN during the next few days. Cheers, ADRIAN |
Davide, you may see that for MULTICLASS cases, the p4 is not working. For multinomial cases, I normally apply an argument called "atom = TRUE/FALSE", which will allow to estimate the value for each class (atom = TRUE) or as a "general/overall" estimate (atom = FALSE). However, I couldn't make it work. Do you think you could help me with a generalization formula of the p4 for multiclass cases? You may check my code attempt with some #hidden lines at this file from lines 105-141. Thank you in advance! Best, ADRIAN |
I meant, it works, but giving weird values (> 1, sometimes negatives). Best, Adrian |
Hi Adrian, |
Hola Adrian
Thanks for having released the
metrica
R package, it is very useful.I have a request: can you please add the P4 metric to the list of available metrics?
The formula is the following one: P4 = (4 * TN * TP) / (4 * TN * TP + (TP + TN)*(FP + FN))
Thanks!
-- Davide
The text was updated successfully, but these errors were encountered: