Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the 'AccountSet' XRP Ledger transaction to xrp-commander tool #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nixer89
Copy link

@nixer89 nixer89 commented Apr 1, 2019

This PR introduces the AccountSet XRPL transaction to the xrp-commander tool:
https://developers.ripple.com/accountset.html

With this change, it would be possible to add/remove a domain from an existing XRP Ledger account.

Additionaly it would be possible to set an 'emailHash' which could show an Avatar and other information:
"Hash of an email address to be used for generating an avatar image. Conventionally, clients use Gravatar to display this image."

Other AccountSet features are not implemented yet because changing these prameters could have a big negative impact on the exisiting XRP Leder account.

@nixer89 nixer89 changed the title Introducing the 'AccountSet' XRP Leder transaction to xrp-commander tool Introducing the 'AccountSet' XRP Ledger transaction to xrp-commander tool Apr 1, 2019
@nixer89
Copy link
Author

nixer89 commented Apr 2, 2019

I also could add a "email" function, so users can easily just add their email address which they use on gravatar instead of providing the actual hash. The tool can then hash the mail and set it to the XRP Ledger account.
This would be a better user experience since they don`t need to login to Gravatar to get the Hash.

@ihomp
Copy link

ihomp commented Apr 12, 2019

good idea, thanks @nixer89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants