Fixes It.IsRegex issue with non-constant arguments #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume the provided argument to It.IsRegex could be any expression so just compile the expression Fixes issue #3
adrianiftode
added a commit
that referenced
this pull request
Nov 26, 2020
The behind loggerMock.Verify was called twice for the times overload. So if times is Times.Never and the sut implementation is valid, the first verify call is not throwing, as expected. But the second loggerMock.Verify was also called with default values and the test reported a false negative, as the sut implementation was correct, but test improperly failed expecting a call on sut's method. Fixes issue #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the provided argument to It.IsRegex could be any expression
so just compile and invoke the expression
Fixes issue #3