Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated assembly references System.Private.CoreLib #41

Closed
adrianoc opened this issue Mar 12, 2020 · 1 comment
Closed

Generated assembly references System.Private.CoreLib #41

adrianoc opened this issue Mar 12, 2020 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@adrianoc
Copy link
Owner

Even though this (kind of ) works this is not correct.

It is related to this issue: jbevain/cecil#646

So basically we'll need to avoid importing types through the reflection like API.

@adrianoc adrianoc added the 🐛 bug Something isn't working label Mar 12, 2020
@adrianoc
Copy link
Owner Author

System.Runtime.dll has a reference to System.Private.CoreLib.dll and typeforwards various types to it.

Maybe a simpler solution would be to run cecilifier normally and at the end replace all references to System.Private.CoreLib.dll with System.Runtime.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant