fix: hilt works with screen instead of android screen #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: back support to activity viewmodel store when using not android lifecycle provider
adrielcafe
approved these changes
Oct 18, 2021
Closed
adrielcafe
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people are using Screen in your android projects with Hilt. Until now voyager is not KMM. So this pull request add support to use Hilt with Screen instead of AndroidScreen. Issues #15 and #17
WARNING: When using Screen in an Android project and you needs a instance of ViewModel the ViewModelStore will be the default provided by your current Activity. So your ViewModel onCleared will be called when Activity is totally destroyed only.
Our recomendations is to use AndroidScreen because it provides a custom ViewModelStore. So if you pop a screen its ViewModel onCleared will be called on pop action instead of wait activity is totally destroyed.
Another fix was changing multibindings to be optional required by #16.