Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial screen and its model not disposing #55

Merged

Conversation

programadorthi
Copy link
Collaborator

This fix is because Navigator dispose checks the last disposed or replaced screen. But first navigator screen will be never popped or replaced because Navigator needs at least one screen to work. Pressing back button or closing applications never dispose first screen.
So here we are putting a effect to dispose based on Navigator been replaced or application been finished. And if a Navigator is totally replaced by another (yes, we can't avoid users does that) it'll will dispose all pushed screens.

@adrielcafe adrielcafe merged commit 16babac into adrielcafe:main Apr 25, 2022
@programadorthi programadorthi deleted the fix/initial-screen-not-disposing branch September 20, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants