Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RailsConf 2024 videos #85

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

marcoroth
Copy link
Collaborator

This pull request adds the RailsConf 2024 videos from this YouTube playlist:

https://www.youtube.com/playlist?list=PLbHJudTY1K0chrs_E_XFz2pOJ3d8jCayh

I used the script from #60 and did some manual tweaking to the YAML file for better formatting and missing information.

Questions:

  • Do we want the "Conference Welcome" and "Day Closing" videos too?
  • Should the published_at date be the date of when the videos were published? Not sure where it inferred 2024-05-21 and 2024-05-24 from. My guess is this is the date when they were uploaded to YouTube and that they were only set to "public" last week.
  • Should we format the YAML files so they are more easily readable? I have a hard time parsing the YAML files in their current form.

@adrienpoly
Copy link
Owner

adrienpoly commented Jul 21, 2024

  • Do we want the "Conference Welcome" and "Day Closing" videos too?

not sure I haven't seen them to me it would make sense to add them if they add relevant content for the ruby community

EDIT I decided to remove the opening and closing videos form Friendly RB as there content wasn't really relevant

  • Should the published_at date be the date of when the videos were published? Not sure where it inferred 2024-05-21 and 2024-05-24 from. My guess is this is the date when they were uploaded to YouTube and that they were only set to "public" last week.
tlk.date = talk_data["published_at"]

The date for the talk model is supposed to be the date when the talk was given. the published_at date is approxiative but at least the talk are chronologically ordered
Ideally we should have the date of the conference, will manually edit them to 2024-05-21

  • Should we format the YAML files so they are more easily readable? I have a hard time parsing the YAML files in their current form.

Sure, do you have a recommendation ?

@adrienpoly adrienpoly merged commit 5d1b4a2 into adrienpoly:main Jul 21, 2024
1 check was pending
@marcoroth marcoroth deleted the railsconf-2024 branch August 1, 2024 06:19
marcoroth added a commit to marcoroth/rubyvideo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants