-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a TUN device and embedded PPP code, instead of using pppd #1048
base: master
Are you sure you want to change the base?
Conversation
6336f54
to
996fe3d
Compare
996fe3d
to
78c6741
Compare
I get these warnings while setting routes after connection:
I get this error when cleaning up because openfortivpn still attempts to terminate `pppd``:
|
becea66
to
ffa926a
Compare
249fb94
to
9b5b6f5
Compare
thank you for applying the TUN patch from @rain2fog. I have just ran a couple of short tests and this appears to work like a charm. Because I use openfortivpn daily I will use this tun branch build from now on to see how it performs. Because I can create a tun device as a normal user I will be running openfortivpn without sudo. Cheers! |
9b5b6f5
to
2dec255
Compare
thank you for the update, will test further with this rev. g2dec255 version. First glance TUN tunnel still working and Route to gateway exists already warnings are also still there. Cheers! |
Yes, I probably won't have time to look into the warnings any time soon. You are welcome to suggest a pull request to fix them. |
6cad092
to
45ca4ae
Compare
Fixed compiler warnings, just took a couple |
6f64a4e
to
77a8990
Compare
Thank you @DimitriPapadopoulos for working on this. When I use the |
8b0dc6b
to
90e6386
Compare
ee0ee45
to
5493005
Compare
Hi, Log
|
@sino1641 Something went wrong with the build process. Restart building from scratch, from a fresh checkout. (you haven't shown the whole build process) |
@DimitriPapadopoulos Thanks for pointing it out. Log
|
There may be a mix-up between The log reads:
so HAVE_LINUX_IF_PPP_H is undefined. But then we include Lines 38 to 40 in 5493005
This raises the following questions:
|
157a0a4
to
800af31
Compare
|
Sincerely thanks Dimitri!
Which means yes Searching Internet, I see that's because some conflicts on musl which Alpine is using so that Lines 44 to 52 in 15ee42a
And for your latest fix, I think this should be a positive status check to define the missing PPP_* macros as behind when <net/if_ppp.h> is missing.
Now it works with all your commits, especially 15ee42a. |
The I understand we need to switch from |
f40efac
to
f99e978
Compare
pppd → tun interface + embedded PPP code
Switch from pppd/ppp to a tun device and internal PPP code.
This commit modifies the `merge_config` function to include the 'tun' value from the source configuration if it is set. Previously, this value was not being merged, leading to inconsistencies in the final configuration. The change checks if 'tun' in the source configuration is different from its default value before merging it into the destination configuration. This ensures that the 'tun' setting is correctly propagated when configurations are merged, allowing for more flexible and accurate VPN setups.
db03fed
to
2d75e9a
Compare
This patch provided by @rain2fog in #801 (comment) works for me. I get a working VPN tunnel without using
pppd
. I wouldn't mind help with reviewing.From #801 (comment):
I get complier warnings on Ubuntu 22.04:
Initially opened as #818.
Fixes #801.