deprecate Integrator.run for integrator.call #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I think it makes sense to bring the API's closer before we all switch over to galax :). Thanks! |
nstarman
force-pushed
the
deprecate-integrator-run
branch
from
8d51606
to
7e09012
Compare
|
Added a test and changelog. |
|
No idea why the testpypi upload step is failing, but it must be unrelated to this PR. Thanks! |
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
adrn
force-pushed
the
deprecate-integrator-run
branch
from
d4d2b1c
to
ac1edf0
Compare
|
Sorry for the long delay on this @nstarman -- it fell off my radar! Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you were interested in this for
gala. If you are, I'll finish the checklist / prune some unneeded lint changes that snuck in here.Checklist
CHANGES.rst)