Cythonize The Joker #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 433a196 on cythonize into ** on master**. |
|
Changes Unknown when pulling 5aa27a3 on cythonize into ** on master**. |
|
Changes Unknown when pulling 43a5524 on cythonize into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know @davidwhogg forbade me from doing this, but I couldn't help it...
This is a rough pass but functional attempt at implementing The Joker likelihood calls in Cython. Local benchmarks indicate a factor of ~8 speedup over the vanilla Joker.
This is built off of the PR #65 so includes those commits as well...