Decode HTML in search result highlights and abstract comments

adsabs · May 20, 2021 · 94a255e · 94a255e
1 parent ced0e1f
commit 94a255e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/src/js/widgets/abstract/templates/abstract_template.html b/src/js/widgets/abstract/templates/abstract_template.html
@@ -176,7 +176,7 @@ <h4 class="sr-only">Abstract</h4>
   {{/if}} {{#if comment}}
   <dt>Comments:</dt>
   <dd>
-    {{ comment }}
+    {{{ comment }}}
   </dd>
   {{/if}} {{#if pubnote}}
   <dt>E-Print Comments:</dt>

diff --git a/src/js/widgets/list_of_things/item_view.js b/src/js/widgets/list_of_things/item_view.js
@@ -34,6 +34,19 @@ define([
     },
 
     render: function() {
+      // // a hacky way to decode html in highglights
+      // if (this.model.get('highlights')) {
+      //   const highlights = this.model.get('highlights');
+      //   this.model.set(
+      //     'highlights',
+      //     highlights.map((h) =>
+      //       $('<textarea/>')
+      //         .html(h)
+      //         .text()
+      //     )
+      //   );
+      // }
+
       if (this.model.get('visible')) {
         return Marionette.ItemView.prototype.render.apply(this, arguments);
       }

diff --git a/src/js/widgets/list_of_things/widget.js b/src/js/widgets/list_of_things/widget.js
@@ -267,6 +267,13 @@ define([
       if (docs && docs.length) {
         // make sure the new docs close highlights if they aren't there
         var newDocs = _.map(docs, function(d) {
+          if (d.highlights) {
+            d.highlights = d.highlights.map((h) =>
+              $('<textarea/>')
+                .html(h)
+                .text()
+            );
+          }
           return _.extend(d, {
             showHighlights: typeof d.highlights !== 'undefined',
             showCheckbox: !!self.model.get('showCheckboxes'),