Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing services and properties #338

Merged
merged 9 commits into from
Jan 21, 2022

Conversation

pcasteran
Copy link
Contributor

Added missing services:

  • Added rebate service
  • Added convert trade service

Added missing properties in some services response:

  • Added missing fields in asset dividende record response.
  • Added missing property 'OrigQuoteOrderQuantity' in Order
  • Added missing property 'OrderListId' in Trade
  • Added missing property 'UnlockConfirm' in Deposit
  • Added missing property 'ConfirmNo' in Withdraw

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #338 (33dc321) into master (afa0336) will decrease coverage by 0.22%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   73.19%   72.96%   -0.23%     
==========================================
  Files          60       62       +2     
  Lines        5637     5693      +56     
==========================================
+ Hits         4126     4154      +28     
- Misses       1120     1140      +20     
- Partials      391      399       +8     
Impacted Files Coverage Δ
v2/asset_dividend_service.go 82.85% <ø> (ø)
v2/deposit_service.go 87.50% <ø> (ø)
v2/order_service.go 75.75% <ø> (ø)
v2/trade_service.go 83.33% <ø> (ø)
v2/withdraw_service.go 86.59% <ø> (ø)
v2/rebate.go 29.62% <29.62%> (ø)
v2/convert_trade.go 64.00% <64.00%> (ø)
v2/client.go 84.40% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa0336...33dc321. Read the comment docs.

@adshao adshao merged commit e767ee6 into adshao:master Jan 21, 2022
@adshao
Copy link
Owner

adshao commented Jan 21, 2022

thanks for the great job @pcasteran

@pcasteran pcasteran deleted the add_more_missing_apis branch January 21, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants