Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blink Homework #52

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

bluemittens505
Copy link

Both versions of the code are included. Version V2 is at the top of blink.js. Version V1 is commented out. I changed index.html so I could test appropriately.

Make plugin work for selectors that correspond to a single element
Make plugin work for selectors that correspond to multiple elements.
function blinkit(obj) {
var value = obj.css('visibility') === 'visible' ? 'hidden' : 'visible';
obj.css('visibility',value);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably put this after line 7 so that you aren't creating any global variables/functions.

@afeld
Copy link
Member

afeld commented Mar 3, 2016

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants