Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Basic explanation of systemd-style config support. #763

Merged
merged 1 commit into from
May 14, 2018

Conversation

pattivacek
Copy link
Collaborator

I just realized this was never updated. This is a pretty basic explanation; is there a definitive source that we should link to for systemd-style configuration?

@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   71.06%   71.06%           
=======================================
  Files          81       81           
  Lines        2523     2523           
=======================================
  Hits         1793     1793           
  Misses        730      730

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91fed08...381b32b. Read the comment docs.

Copy link
Collaborator

@tkfu tkfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, and would happily merge it as-is. I do have one or two clarifying questions, though:

  1. What happens if I have a config file that doesn't specify a value for an option that gets processed after a config file that does? That is, does the overruling happen on the per-option level, or per-file level?
  2. If I specify a config file on the command line, is that the only one that gets processed, or is it just that it's the last one that's processed?

@cajun-rat cajun-rat merged commit 7a999f7 into master May 14, 2018
@cajun-rat cajun-rat deleted the doc/systemd-config branch May 14, 2018 15:19
@pattivacek
Copy link
Collaborator Author

@tkfu:

  1. There are two steps. Searching by file name overrules per unique file name, then processing the options overrules per option.
  2. Yes, if --config is specified at least once, the defaults are not used.

I made some meaning tweaks here: #766

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants