Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional helper functions #2

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Add additional helper functions #2

merged 7 commits into from
Oct 20, 2022

Conversation

ramasauskas
Copy link
Contributor

This pull request introduces several helper functions (and variables) that make xdecimal more comfortable to use.

@ramasauskas ramasauskas changed the title Add additional functions Add additional helper functions Oct 17, 2022
Copy link
Member

@Amfii Amfii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use receiver functions now that we are using a fork which should make fresh migration from advbet/decimal even easier.

decimal.go Outdated Show resolved Hide resolved
decimal.go Outdated Show resolved Hide resolved
@davseby
Copy link

davseby commented Oct 18, 2022

I hadn't had a chance to comment the first pr, but there a lot of shopspring repository references left in the README (e.g cards).

@ramasauskas
Copy link
Contributor Author

@davseby addressed in #3

decimal_test.go Outdated Show resolved Hide resolved
decimal.go Show resolved Hide resolved
decimal.go Outdated Show resolved Hide resolved
@ramasauskas ramasauskas merged commit 59cdcde into master Oct 20, 2022
@ramasauskas ramasauskas deleted the additional_funcs branch October 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants