-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Irregular Grid Appearance #83
Comments
If we are going to have an irregular grid, I think the images should flow along with the text. Currently it is leaving gaps. Would it be possible to have perhaps the following classed options?
Is there a reason you used HR's for the horizontal lines instead of borders, @tpitre? |
@designerbrent I can update them to use styles borders if you prefer that. I typically use I'll update the grid styles to include an option for a uniform grid. |
I never thought about the HR but that does make a bit of sense as a divider, @tpitre, it's just different then I have used it before. Semantically it makes sense, though. Having a uniform grid option will be helpful. |
This option is now in place in ALPS. I haven't yet had time to update the documentation so currently, there is no place it's mentioned. |
@designerbrent There's a small description in the code here, if that helps. |
The placing of the horizontal lines in the content grid (http://alps.adventist.io/public/?p=organisms-grid-3up-content) makes the grid appear to be an irregular grid, when it is in fact a very neat, regular, well-aligned grid:
Would it perhaps make sense to tweak that so that all the lines aligned in a line?
Or, as Martin would put it, would it make sense to convert
.with-divider
to add aborder-top
to the container and aborder-bottom
to individual.gi .pad
elements? This would remove the need for<hr>
tags. A second class could be added to do equal height columns by putting thebottom-border
on.gi
.Then it could look like the following example where all the content was luckily the same length.
The text was updated successfully, but these errors were encountered: