Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular Grid Appearance #83

Closed
ivanruizknott opened this issue Sep 22, 2016 · 6 comments
Closed

Irregular Grid Appearance #83

ivanruizknott opened this issue Sep 22, 2016 · 6 comments
Assignees

Comments

@ivanruizknott
Copy link

The placing of the horizontal lines in the content grid (http://alps.adventist.io/public/?p=organisms-grid-3up-content) makes the grid appear to be an irregular grid, when it is in fact a very neat, regular, well-aligned grid:

screen shot 2016-09-22 at 12 16 47 pm

screen shot 2016-09-22 at 12 24 44 pm

Would it perhaps make sense to tweak that so that all the lines aligned in a line?

Or, as Martin would put it, would it make sense to convert .with-divider to add a border-top to the container and a border-bottom to individual .gi .pad elements? This would remove the need for <hr> tags. A second class could be added to do equal height columns by putting the bottom-border on .gi.

Then it could look like the following example where all the content was luckily the same length.

screen shot 2016-09-22 at 12 17 55 pm

@designerbrent
Copy link
Collaborator

If we are going to have an irregular grid, I think the images should flow along with the text. Currently it is leaving gaps.

Would it be possible to have perhaps the following classed options?

  • Regular Grid
  • Irregular Grid
  • Dividers (This would apply the lines between the grids.)

Is there a reason you used HR's for the horizontal lines instead of borders, @tpitre?

@tpitre
Copy link
Collaborator

tpitre commented Sep 27, 2016

@designerbrent I can update them to use styles borders if you prefer that. I typically use <hr>'s to divide chunks of content, but it's more of a styling preference. They also help with spacing since they can be styled.

I'll update the grid styles to include an option for a uniform grid.

@designerbrent
Copy link
Collaborator

I never thought about the HR but that does make a bit of sense as a divider, @tpitre, it's just different then I have used it before. Semantically it makes sense, though.

Having a uniform grid option will be helpful.

@designerbrent
Copy link
Collaborator

This option is now in place in ALPS. I haven't yet had time to update the documentation so currently, there is no place it's mentioned.

@tpitre
Copy link
Collaborator

tpitre commented Oct 3, 2016

@designerbrent There's a small description in the code here, if that helps.

@designerbrent
Copy link
Collaborator

That's great, @tpitre. I just need to get that into the grid page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants