Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples to document Layouts and Grids #57

Merged
merged 2 commits into from
Aug 24, 2016

Conversation

designerbrent
Copy link
Collaborator

ADDED: A new example pattern that shows both grids and layouts and all their current options. This replaces their individual layout and grid pattern pages.

@tpitre Do you see a problem removing the individual example patterns?

…l their current options. This replaces their individual layout and grid pattern pages.
@@ -0,0 +1,98 @@
<div class="grids">
<div class="pad">
<ul class="bullet-list">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some off indenting or an unclosed tag here.

@designerbrent
Copy link
Collaborator Author

Oops. Forgot to indent everything out. Should be corrected now.

</ul>
</div>

<div class="pad">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the .pad classes to create spacing is totally fine, but we have this list of helper spacing classes to help create uniform spacing without having to add classes to each element. To use it, just wrap a section of direct child elements that you want to have equal distance apart.

<div class="spacing">
  <div></div> <!-- no effect (doesn't create space for the immediate descendant) -->
  <div></div> <!-- spaced -->
  <div>
    <div></div> <!-- no effect -->
  </div> <!-- spaced -->
  <div></div> <!-- spaced -->
<div>

@tpitre
Copy link
Collaborator

tpitre commented Aug 24, 2016

@designerbrent This looks great! Yes, removing those individual patterns is ok. They were only being utilized within the style guide and not actually included into any templates.

@designerbrent
Copy link
Collaborator Author

@tpitre This really opened my eyes to what is available. I'll be digging into more of these code files as we go.

@designerbrent designerbrent merged commit 29921e2 into master Aug 24, 2016
@tpitre tpitre deleted the 56-example-grids-layouts branch August 24, 2016 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants