Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 100 #103

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Issue 100 #103

merged 6 commits into from
Oct 1, 2021

Conversation

svteichman
Copy link
Collaborator

Adding speedyseq to suggests, and then adding its URL to Additional_repositories in DESCRIPTION as described here https://cran.r-project.org/web/packages/policies.html. Additionally adding lines in each vignette to load speedyseq instead of phyloseq if it is installed

…ndencies part of R-CMD-check.yaml and test-coverage.yaml
@svteichman svteichman requested review from ailurophilia and removed request for paulinetrinh September 29, 2021 23:27
@codecov-commenter
Copy link

Codecov Report

Merging #103 (0d30e60) into master (97941e2) will increase coverage by 13.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #103       +/-   ##
===========================================
+ Coverage   52.33%   65.95%   +13.62%     
===========================================
  Files          13       13               
  Lines         793      796        +3     
===========================================
+ Hits          415      525      +110     
+ Misses        378      271      -107     
Impacted Files Coverage Δ
R/s3functions.R 56.07% <0.00%> (+39.96%) ⬆️
R/beta_diversity_helper.R 96.00% <0.00%> (+96.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b94e4...0d30e60. Read the comment docs.

Copy link
Collaborator

@ailurophilia ailurophilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I uninstalled speedyseq and ran devtools:build() locally and had no problems, so I think we're good!

@ailurophilia ailurophilia merged commit 94011b1 into adw96:master Oct 1, 2021
@svteichman svteichman deleted the issue_100 branch June 13, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants