-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 100 #103
Issue 100 #103
Conversation
…if it is installed (and phyloseq if not) in order to use speedyseq for tax_glom()
…rom cran and having it in suggests is causing checks to fail
…::install_github("mikemc/speedyseq")
…ndencies part of R-CMD-check.yaml and test-coverage.yaml
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
===========================================
+ Coverage 52.33% 65.95% +13.62%
===========================================
Files 13 13
Lines 793 796 +3
===========================================
+ Hits 415 525 +110
+ Misses 378 271 -107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I uninstalled speedyseq and ran devtools:build() locally and had no problems, so I think we're good!
Adding speedyseq to suggests, and then adding its URL to Additional_repositories in DESCRIPTION as described here https://cran.r-project.org/web/packages/policies.html. Additionally adding lines in each vignette to load speedyseq instead of phyloseq if it is installed