Fix repl #6
Merged
Fix repl #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| flatten | ||
| distinct | ||
| (remove nil?) | ||
| (apply merge-with concat)))) |
There was a problem hiding this comment.
I'd like some suggestion how to make this more concise if possible.
There was a problem hiding this comment.
Maybe
(defn get-upstream-deps []
"The way Clojurescript handles this does not work when
using classloaders in the fancy ways we do."
(->> (pod/classloader-resources "deps.cljs")
(keep second)
(mapcat identity)
(map (comp read-string slurp))
(apply merge-with concat)))I didn't thoroughly test, but keep is maybe useful here.
There was a problem hiding this comment.
Nice didn't know about keep 💯
There was a problem hiding this comment.
@alandipert that seems to work :)
|
@micha can we merge & deploy this please? |
|
Just deployed 0.1.9 also 🍻 |
|
🍻 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this relies on boot-clj/boot-cljs#50 but I'm not entirely sure.