Fix/react native #58
Merged
Fix/react native #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a JavaScript environment that does not involve a browser (such as react native), don't expect a DOM to be available. Instead check that window.document.documentURI exists, an assumption that should be true even for old browsers.
|
@pesterhazy looks good to me. 👍 I'll wait for @Deraen to give his ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes boot-reload work from react-native (especially https://github.com/mjmeintjes/boot-react-native/) and other non-browser related. Also renames option to
disable-hud(though this flag is not needed in a non-browser environment anymore). For details, please see individual commit messages.