add Bandwidth type #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `Bandwidth` type
that represents a Size per second.
We consider `Bandwidth` to be always normalized
to 1s. Most users will probably care only ever
about sizes per second, e.g. MB/s and not about
e.g. MB/ms.
Further, it is easy to add or subtract bandwidths.
For example:
```
1.5MB/s = 1MB/s + 500KB/s
```
When dealing with arbitrary durations like 1MB/1.7ms
a different type may be better suited:
```
type Rate struct {
N Size
T time.Duration
}
```
Signed-off-by: Andreas Auernhammer <hi@aead.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
Bandwidthtypethat represents a Size per second.
We consider
Bandwidthto be always normalizedto 1s. Most users will probably care only ever
about sizes per second, e.g. MB/s and not about
e.g. MB/ms.
Further, it is easy to add or subtract bandwidths. For example:
When dealing with arbitrary durations like 1MB/1.7ms a different type may be better suited: