Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE !!! Using-utc-datetime-to-comunicate-with-api #121

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

maximeroucher
Copy link
Member

@maximeroucher maximeroucher commented Aug 20, 2023

Goal of this PR : Using Utc dates

Description of the added features :

  • Using utc dates when communicating with Hyperion
  • Changing them to local in the app

Required unmerged PR :

Other information :

  • Answer of 114

@maximeroucher maximeroucher linked an issue Aug 20, 2023 that may be closed by this pull request
@maximeroucher maximeroucher added enhancement New feature or request core This PR change the core ready for review This PR is ready to be reviewed labels Aug 20, 2023
@maximeroucher maximeroucher changed the title Using-utc-datetime-to-comunicate-with-api DO NOT MERGE !!! Using-utc-datetime-to-comunicate-with-api Aug 22, 2023
@guillaumetavernier
Copy link
Contributor

Need to be rebase to match : aeecleclair/Hyperion#360

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.62%. Comparing base (b601bc7) to head (be18a1e).

Files Patch % Lines
lib/recommendation/class/recommendation.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   55.57%   55.62%   +0.04%     
==========================================
  Files         166      166              
  Lines        3570     3574       +4     
==========================================
+ Hits         1984     1988       +4     
  Misses       1586     1586              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 force-pushed the Using-utc-datetime-to-comunicate-with-api branch from 90ebb54 to 1c53c01 Compare March 14, 2024 09:24
@julien4215 julien4215 force-pushed the Using-utc-datetime-to-comunicate-with-api branch from ec1aa2c to be18a1e Compare March 15, 2024 12:27
@julien4215 julien4215 merged commit d23d5d6 into main Mar 16, 2024
7 checks passed
@julien4215 julien4215 deleted the Using-utc-datetime-to-comunicate-with-api branch March 16, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This PR change the core enhancement New feature or request ready for review This PR is ready to be reviewed waiting backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending time as UTC to Hyperion
5 participants