Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Amap) Use constants for slots #299

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Conversation

guillaumetavernier
Copy link
Contributor

@guillaumetavernier guillaumetavernier commented Feb 21, 2024

Close #298

Screenshot_2024-02-21-08-25-29-08_3166164293b8afe0deb3263e48924357.jpg

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea99eb6) 56.46% compared to head (53030d6) 56.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   56.46%   56.45%   -0.02%     
==========================================
  Files         159      160       +1     
  Lines        3482     3488       +6     
==========================================
+ Hits         1966     1969       +3     
- Misses       1516     1519       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumetavernier guillaumetavernier added the ready for review This PR is ready to be reviewed label Feb 22, 2024
@guillaumetavernier guillaumetavernier merged commit 6b6e4a2 into main Feb 24, 2024
6 checks passed
@julien4215 julien4215 deleted the amap-translation branch February 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMAP slots are not translated
4 participants