Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change loan history order #310

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Change loan history order #310

merged 5 commits into from
Mar 16, 2024

Conversation

julien4215
Copy link
Collaborator

@julien4215 julien4215 commented Mar 1, 2024

Closes #252.

Requires aeecleclair/Hyperion#352

@julien4215 julien4215 added the loan label Mar 1, 2024
@julien4215 julien4215 marked this pull request as draft March 2, 2024 21:42
@julien4215 julien4215 marked this pull request as ready for review March 4, 2024 11:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.54%. Comparing base (d23d5d6) to head (086db25).

Files Patch % Lines
lib/loan/class/loan.dart 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   55.56%   55.54%   -0.02%     
==========================================
  Files         166      166              
  Lines        3585     3586       +1     
==========================================
  Hits         1992     1992              
- Misses       1593     1594       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 added the ready for review This PR is ready to be reviewed label Mar 16, 2024
julien4215 added a commit to aeecleclair/Hyperion that referenced this pull request Mar 16, 2024
This change is required for the PR
aeecleclair/Titan#310.

It should be merged after #360
@julien4215 julien4215 merged commit ec19862 into main Mar 16, 2024
5 checks passed
@julien4215 julien4215 deleted the fix/loan-history-order branch March 16, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loan ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order returned loans by return date
4 participants