Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(settings): disable logs for web #316

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

guillaumetavernier
Copy link
Contributor

As it is not possible to use file storage on web browsers, logs may also be disabled for MyECL Web

Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also disable the route accessing the logs page, to prevent any error

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.01%. Comparing base (3791c95) to head (1185f7c).

Files Patch % Lines
lib/tools/logs/logger.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   56.03%   56.01%   -0.02%     
==========================================
  Files         161      161              
  Lines        3514     3515       +1     
==========================================
  Hits         1969     1969              
- Misses       1545     1546       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumetavernier guillaumetavernier merged commit 3413630 into main Mar 2, 2024
5 checks passed
@guillaumetavernier guillaumetavernier deleted the fix/disable-logging-web branch March 2, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants