Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flavor on the web using flutter dart-define #331

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

armanddidierjean
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.83%. Comparing base (99fc0b9) to head (2cbb9d2).

Files Patch % Lines
lib/tools/functions.dart 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   54.87%   54.83%   -0.04%     
==========================================
  Files         166      166              
  Lines        3665     3669       +4     
==========================================
+ Hits         2011     2012       +1     
- Misses       1654     1657       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@armanddidierjean armanddidierjean added core This PR change the core fix bug This PR fix a bug ci/cd This PR works on the CI/CD labels Mar 19, 2024
Copy link
Collaborator

@julien4215 julien4215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep defining two different environments for alpha and prod because we should not use the same value for PLAUSIBLE_HOST and PLAUSIBLE_DOMAIN in alpha or production.

@julien4215 julien4215 merged commit d8a5c03 into main Mar 20, 2024
3 checks passed
@julien4215 julien4215 deleted the flavor-for-web branch March 20, 2024 15:11
@julien4215 julien4215 mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd This PR works on the CI/CD core This PR change the core fix bug This PR fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants