Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing calls to movie API #338

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Removing calls to movie API #338

merged 6 commits into from
Jun 5, 2024

Conversation

Marc-Andrieu
Copy link
Contributor

@Marc-Andrieu Marc-Andrieu commented Mar 25, 2024

  • removing calls to the movie API
  • removing the only token from the .env file
  • tried to communicate with Hyperion in order to request the same data about movies

Close #112
Require aeecleclair/Hyperion#385

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.01%. Comparing base (e7f5550) to head (01e8c8a).

Files Patch % Lines
...b/cinema/repositories/the_movie_db_repository.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   53.87%   54.01%   +0.13%     
==========================================
  Files         169      168       -1     
  Lines        3727     3710      -17     
==========================================
- Hits         2008     2004       -4     
+ Misses       1719     1706      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marc-Andrieu Marc-Andrieu marked this pull request as ready for review May 25, 2024 16:31
@Marc-Andrieu
Copy link
Contributor Author

Marc-Andrieu commented May 30, 2024

Requires Hyperion#385

@Marc-Andrieu
Copy link
Contributor Author

Closes #112

@Marc-Andrieu Marc-Andrieu merged commit 4ea36c2 into main Jun 5, 2024
3 checks passed
@maximeroucher maximeroucher deleted the cinema_api branch June 5, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the MOVIE DB API key from Titan
4 participants