Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresher issue #341

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Fix refresher issue #341

merged 1 commit into from
Mar 30, 2024

Conversation

julien4215
Copy link
Collaborator

@julien4215 julien4215 commented Mar 29, 2024

I removed the endpoint GET phonebook/associations/{association_id} because it doesn't exist in Hyperion.

It was causing issues with refresher widget on some pages of the module.

@julien4215 julien4215 added fix bug This PR fix a bug phonebook This PR works on the phonebook module labels Mar 29, 2024
@julien4215 julien4215 marked this pull request as draft March 29, 2024 16:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (2e48e2b) to head (19b00d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files         166      166           
  Lines        3669     3669           
=======================================
  Hits         2012     2012           
  Misses       1657     1657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximeroucher maximeroucher merged commit 0f08360 into main Mar 30, 2024
7 checks passed
@maximeroucher maximeroucher deleted the fix/phonebook branch March 30, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build fix bug This PR fix a bug phonebook This PR works on the phonebook module ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants