-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init logs and escape messages and refactor loggers #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I look like a clown for this one 😄
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 54.78% 54.71% -0.08%
==========================================
Files 166 168 +2
Lines 3665 3670 +5
==========================================
Hits 2008 2008
- Misses 1657 1662 +5 ☔ View full report in Codecov by Sentry. |
instead of constructing the log by hand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one !
We changed the way logs are stored in a file, thus the app will be unable to parse already existing logs.
|
Add a new structure to use different LoggerOutput on the web and on mobile devices. PrintLoggerOutput can be used on the web to display logs in the console.
Closes #226
Closes #277
How to tests?
As we use two LoggerOutput, one on the web and one on mobile devices, the two platform should be tested.
On the web:
DATE | LEVEL | MESSAGE
was printed in the consoleOn iOS/Android: