Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowing amap admin to add negative price #370

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

maximeroucher
Copy link
Member

Goal of this PR : Allow amap admin to add negative prices

Description of the added features :

  • Change textEntry to support negative integer entry

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.01%. Comparing base (87c331f) to head (1411d19).

Current head 1411d19 differs from pull request most recent head 246caec

Please upload reports for the commit 246caec to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files         168      168           
  Lines        3710     3710           
=======================================
  Hits         2004     2004           
  Misses       1706     1706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Foukki Foukki force-pushed the feat/supporting-negative-int-input branch from 49d5b68 to 091baf5 Compare June 11, 2024 13:24
Copy link
Contributor

@Marc-Andrieu Marc-Andrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems silly, it only changes the UI, but it works and was asked by the AMAP 🤷‍♂️

@Foukki Foukki merged commit 2842c97 into main Jun 11, 2024
3 checks passed
@Foukki Foukki deleted the feat/supporting-negative-int-input branch June 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants