Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loan #376

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix loan #376

merged 2 commits into from
Jun 4, 2024

Conversation

Foukki
Copy link
Contributor

@Foukki Foukki commented May 31, 2024

This PR deletes sorting, it is too bad but it breaks the module.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.87%. Comparing base (afe8f5e) to head (b63d780).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         169      169           
  Lines        3727     3727           
=======================================
  Hits         2008     2008           
  Misses       1719     1719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 added loan fix bug This PR fix a bug labels Jun 1, 2024
@julien4215 julien4215 linked an issue Jun 1, 2024 that may be closed by this pull request
Copy link
Contributor

@Marc-Andrieu Marc-Andrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: it works

@Foukki Foukki merged commit ce2cbe9 into main Jun 4, 2024
8 checks passed
@Foukki Foukki deleted the fix-loan branch June 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug This PR fix a bug loan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loan editing issue
4 participants