Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse gesture is really collapse to top #732

Closed
QuarterSwede opened this issue Sep 12, 2023 · 1 comment · Fixed by #862
Closed

Collapse gesture is really collapse to top #732

QuarterSwede opened this issue Sep 12, 2023 · 1 comment · Fixed by #862
Labels
enhancement New feature or request parity:apollo

Comments

@QuarterSwede
Copy link

When collapsing a child comment by using the swipe gesture “collapse,” the parent is collapsed instead of the intended child only. If this is the intended behavior the gesture should be renamed “collapse to top” to be in line with the 3 dot menu wording on comments.

If it’s not intended, then the collapse gesture needs to collapse only the child, as in the tapping functionality when tapping on a child comment to collapse.
@aeharding
Copy link
Owner

Thanks! I agree, we can have both gestures.

@aeharding aeharding added enhancement New feature or request parity:apollo labels Sep 24, 2023
aeharding added a commit that referenced this issue Oct 29, 2023
@aeharding
Add collapse comment gesture
0dc12e3 
- Rename collapse => collapse to top

Resolves #732
aeharding added a commit that referenced this issue Oct 29, 2023
@aeharding
Add collapse comment gesture
442f0fb 
- Rename collapse => collapse to top

Resolves #732
@aeharding aeharding mentioned this issue Oct 29, 2023
Merged
aeharding added a commit that referenced this issue Oct 29, 2023
@aeharding
Add collapse comment gesture (#862)
3ec10f7 
- Add collapse comment gesture
- Rename collapse => collapse to top

Resolves #732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request parity:apollo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add collapse comment gesture aeharding/voyager
2 participants
@aeharding @QuarterSwede