handle ::shorthand/keywords #1
Conversation
|
Thank you for the pull request. Before merging, I'd prefer to have a new entry in the unit tests that confirms that the parser not only makes it through the string without throwing an error, but also can still white out source code correctly with a double-colon keyword. |
| (defn disabled-read-keyword | ||
| "Read ::foo/keywords without context" | ||
| [rdr _ opts pending-forms] | ||
| (let [form (#'rdr/read* rdr true nil opts pending-forms)] |
There was a problem hiding this comment.
This is a more general, possibly unpredictable attempt at reading keywords. For example, if I'm interpreting the implications of this implementation correctly, ::::::[::#{}] is now a valid keyword. To be on the safer side, could you please rewrite this as a similar implementation to the real read-keyword, that simply eliminates the "second :" logic?
|
certainly, here are the tests |
|
I've implemented slightly more sophisticated parsing of keywords. Not because I think we should reject invalid clojure, but because of a fix for :2number-keywords. |
|
Looks good. Thanks again. When I get the chance sometime today, I will merge / deploy this. |
|
Deployed |
right now, cljsee throws when encountering
::alias/keywords. This patch fixes it.