Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix older versions in dashboard #102

Merged
merged 1 commit into from Apr 26, 2024
Merged

Fix older versions in dashboard #102

merged 1 commit into from Apr 26, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Apr 25, 2024

Workaround for vmware-tanzu/kubeapps#7740

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Workaround for vmware-tanzu/kubeapps#7740

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Copy link
Member

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some kind of hard code, can we put the url generation into some variable?

@kvaps
Copy link
Member Author

kvaps commented Apr 26, 2024

Unfortunately no, because we generate static files which then go into image with cozystack.
We can do runtime generation, but from my perspective it's better to have less moving parts as possible :)

@kvaps kvaps requested a review from themoriarti April 26, 2024 08:21
Copy link
Member

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so far we accept it.

@themoriarti themoriarti merged commit ff9ab5b into main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants