Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement podSpec generation #72

Merged
merged 9 commits into from
Mar 24, 2024
Merged

feat: Implement podSpec generation #72

merged 9 commits into from
Mar 24, 2024

Conversation

sergeyshevch
Copy link
Member

@sergeyshevch sergeyshevch commented Mar 22, 2024 •
edited
Loading

Fixes #69

Base automatically changed from feature/49-impl-spec-storage to main March 23, 2024 09:11
@sergeyshevch sergeyshevch marked this pull request as ready for review March 23, 2024 18:21
@sergeyshevch sergeyshevch mentioned this pull request Mar 23, 2024
Closed
@sergeyshevch sergeyshevch changed the title feat: Add statefulSet reconcile function feat: Implement podSpec generation Mar 23, 2024
sircthulhu
sircthulhu requested changes Mar 23, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just fix update validator and add license header to each go file please

api/v1alpha1/etcdcluster_webhook.go Show resolved Hide resolved
@sergeyshevch
Copy link
Member Author

sergeyshevch commented Mar 24, 2024 •
edited
Loading

add license header to each go file please

Fixed

sircthulhu
sircthulhu approved these changes Mar 24, 2024
View reviewed changes
internal/controller/factory/suite_test.go Outdated Show resolved Hide resolved
@sircthulhu sircthulhu merged commit b3547a0 into main Mar 24, 2024
3 checks passed
This was referenced Mar 25, 2024
Closed
Closed
@sircthulhu sircthulhu added the feature New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sircthulhu sircthulhu sircthulhu approved these changes

@Kirill-Garbar Kirill-Garbar Kirill-Garbar approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PodSpec for EtcdCluster CRD
3 participants
@sergeyshevch @sircthulhu @Kirill-Garbar