-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add estimator overview table with capabilities #1426
[DOC] Add estimator overview table with capabilities #1426
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overview table. It already provides a good overview and the capabilities are displayed as well. For now, one can just use the browsers search functionality to navigate it. 👍🏼
The generation-function contains quite a lot of code. Should we extract it to a separate file?
There is also build_tools/generate_developer_tables.py
, which also generates an html table... I don't know if this is similar enough, though.
The trick is that it should be generated while building the docs, and I don't know if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I agree searching can wait with an issue raised. Do we want to close #1242? There is still an issue maybe in not having tags on individual API pages.
Reference Issues/PRs
Fixes #1242
What does this implement/fix? Explain your changes.
Add back the estimator overview table from 0.3, but add capabilities of individual estimators to the table.
When this is merged, i'll raise an issue for the sorting by columns / search function that I didn't manage to implement.