Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add DummyClusterer #1567

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

aadya940
Copy link
Contributor

Closes #1528 .

@aeon-actions-bot aeon-actions-bot bot added clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement labels May 25, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, but could you also test the _score function for coverage?

@aadya940
Copy link
Contributor Author

great stuff, but could you also test the _score function for coverage?

I will, sorry for the oversight. 🙂

@aadya940
Copy link
Contributor Author

@TonyBagnall Hello, I don't think the failure is related to this PR. wdyt?

@MatthewMiddlehurst
Copy link
Member

Agreed, rerunning it.

Unrelated to this PR but I'm not sure I'm a fan of score being the way it is currently. See #1530.

@TonyBagnall TonyBagnall merged commit 660cb0f into aeon-toolkit:main Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Implement DummyClusterer
3 participants