feat(pagination): re-importing from AIP-158 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEP-158 forked from the general aip.dev, whose guidance diverged a bit from gooogle.aip.dev. This re-imports those, resulting in the following set of changes: - switching typescript examples to proto (with placeholder for openapi). - minor wording fixes.
rofrankel
requested changes
Apr 26, 2024
There was a problem hiding this comment.
A lot of the changes in this PR take generic wording and make it proto-specific (outside the protobuf tab). Other changes revert the improvement from page_size to max_page_size.
I commented on the first instance of each that I noticed, but not on all instances.
Co-authored-by: Richard Frankel <richard@frankel.tv>
- adding definition for schema - renaming page_size -> max_page_size - normalize verbase to use method vs operation / rpc
rofrankel
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AEP-158 forked from the general aip.dev, whose guidance diverged a bit from google.aip.dev.
This re-imports those, resulting in the following set of changes:
Fixes #12
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)