Adopt AIP-0203: Field Behavior #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We definitely need OpenAPI variants - I'll file an issue at least. |
toumorokoshi
requested changes
Apr 21, 2024
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
toumorokoshi
approved these changes
Apr 27, 2024
mkistler
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Need to change "name" to "path" in a bunch of places (I think I caught them all).
After that I think we should merge this. I think this AEP will require extensive changes to generalize the guidance and then add OAS-specifics, so we should do that in a separate PR.
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
mkistler
approved these changes
May 6, 2024
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Proto changes in aep-dev/aep#13
It's unclear to me if we need an OpenAPI extension, but I'd guess we do?
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)Additional checklist for a new AEP
guidelines are met.
Document structure
guidelines are met.
💝 Thank you!