FieldManager add namespace for Aeraki #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanjunchen
force-pushed
the
optimize-code
branch
from
8f3b2ac
to
9786e2f
Compare
zhaohuabing
reviewed
Apr 20, 2023
pkg/config/constants/constants.go
Outdated
Comment on lines
26
to
27
| // True: The generated envoyFilters will be placed under the service namespace | ||
| DefaultAerakiEnableEnvoyFilterNsScopeName = "AERAKI_ENABLE_ENVOY_FILTER_NS_SCOPE" |
There was a problem hiding this comment.
I prefer “AerakiEnableEnvoyFilterNsScope” because it's just a env name, not a default value.
pkg/envoyfilter/controller.go
Outdated
| LabelSelector: "manager=" + constants.AerakiFieldManager, | ||
| }) | ||
| listNamespace := "" | ||
| if c.namespaceScoped { |
There was a problem hiding this comment.
Envoyfilters can exist in multiple namespaces, not only in the root namespace.
tanjunchen
force-pushed
the
optimize-code
branch
from
9786e2f
to
c44d929
Compare
tanjunchen
changed the title
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
tanjunchen
force-pushed
the
optimize-code
branch
from
c44d929
to
d28efed
Compare
zhaohuabing
reviewed
Apr 23, 2023
| // DefaultAerakiEnableEnvoyFilterNsScope is the name for Aeraki to place envoyFilters scope | ||
| // False(Default): The generated envoyFilters will be placed under Istio root namespace | ||
| // True: The generated envoyFilters will be placed under the service namespace | ||
| DefaultAerakiEnableEnvoyFilterNsScope = "AERAKI_ENABLE_ENVOY_FILTER_NS_SCOPE" |
There was a problem hiding this comment.
Maybe just AerakiEnableEnvoyFilterNsScope as it's an Env name, not a default value.
zhaohuabing
reviewed
Apr 23, 2023
| @@ -105,7 +107,7 @@ func (c *namespaceController) createBootstrapConfigMap(ns string) { | |||
| "custom_bootstrap.json": GetBootstrapConfig(c.AerakiAddr, c.AerakiPort), | |||
| } | |||
| if err := c.Client.Create(context.TODO(), cm, &controllerclient.CreateOptions{ | |||
| FieldManager: constants.AerakiFieldManager, | |||
| FieldManager: constants.AerakiFieldManager + "-" + c.rootNamespace, | |||
There was a problem hiding this comment.
There're two problems here:
- The change of FieldManager will break existing Aeraki deployment since old resources were created with “constants.AerakiFieldManager", the change should be back compatible
- I prefer geting FiledManager value from a central place rather than passing rootNamespace around everywhere
|
Hold this until we have a clear design how multi-tenants would work. |
|
This PR is related to #330 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
/reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Pre-Submission Checklist: