Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish functions ModifyValue and WithUpdate. #23

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

fujiwara
Copy link
Contributor

Hi. Thank you for a great library!

jsondiff works perfectly to create diff by ignoring some elements. See also fujiwara/lambroll#281

So I'm considering using jsondiff to ignore some elements of json structures.

In this PR https://github.com/fujiwara/lambroll/pull/283/files, I try to ignore specified elements in json before creating parameters for deployment.

I want to use jsondiff.ModifyValue and WithUpdate from outside this package.

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 69.54% // Head: 69.54% // No change to project coverage 👍

Coverage data is based on head (eb9aae8) compared to base (3689e59).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   69.54%   69.54%           
=======================================
  Files           2        2           
  Lines         197      197           
=======================================
  Hits          137      137           
  Misses         42       42           
  Partials       18       18           
Impacted Files Coverage Δ
diff.go 72.46% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aereal aereal merged commit 2e79707 into aereal:main Dec 31, 2022
@aereal
Copy link
Owner

aereal commented Dec 31, 2022

Thank you for contributing and using this library!

@fujiwara fujiwara deleted the publish-funcs branch January 4, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants